Endless recursion in CreateKeyEditor(...) (2.03.08)

Unreal Engine
1

Hi!

After updating to FMOD 2.03.08 we had reports of our editor crashing when sequences are edited.
Seems like an endless recursion was introduced in CreateKeyEditor (FMODChannelEditors.cpp):

TSharedRef<SWidget> CreateKeyEditor(const TMovieSceneChannelHandle<FFMODEventControlChannel> &Channel, const UE::Sequencer::FCreateKeyEditorParams& Params)
{
    const FFMODEventControlChannel *RawChannel = Channel.Get();

    if (!RawChannel)
    {
        return SNullWidget::NullWidget;
    }

    UEnum *Enum = RawChannel->GetEnum();
	return CreateKeyEditor(Channel.Cast<FFMODEventControlChannel>(), Params);
}

Pretty sure that last line above is supposed to read:

return SNew(SFMODEventControlKeyEditor, Channel, Params.OwningSection, Params.Sequencer, Enum);

Ciao, Daniel!

1 Like
2

This is the fix we have ready to go out once we finish testing this and some other fixes.